Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute threads by altering rendering #606

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

ksedgwic
Copy link
Contributor

Previous approach was to keep muted content from getting inserted.

Instead, this version alters it's display. This makes toggling mutes on and off externally much more stable (the display changes but we don't have to rebuild content trees)

For now muted content is collapsed to a red "Muted" tombstone.

This PR replaces #604

@ksedgwic ksedgwic mentioned this pull request Dec 20, 2024
- they need to be separate, both on at once is too much

    --features debug-widget-callstack
      Show callstack for the current widget on hover if all modifier keys
      are pressed down

    --features debug-interactive-widgets
      Show an overlay on all interactive widgets

    Notes:
    - debug-widget-callstack asserts `egui:callstack` feature when enabled
    - Only works in debug builds, compile error w/ release builds
Previous approach was to keep muted content from getting inserted.

Instead, this version alters it's display.  This makes toggling mutes
on and off externally much more stable (the display changes but we
don't have to rebuild content trees)

For now muted content is collapsed to a red "Muted" tombstone w/ a reason.
@ksedgwic ksedgwic force-pushed the 2024-12-mute-thread-display branch from 09aeddd to e193e00 Compare January 2, 2025 23:23
@ksedgwic
Copy link
Contributor Author

ksedgwic commented Jan 2, 2025

rebased and added mute reason to the UI

@jb55 jb55 merged commit 212c296 into damus-io:master Jan 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants